Add second placeholder to duplicate display names error message#3092
Draft
Add second placeholder to duplicate display names error message#3092
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: MrHinsh <5205575+MrHinsh@users.noreply.github.com>
Base automatically changed from
3090-You-have-two-users-with-identical-display-names
to
main
January 8, 2026 16:31
Copilot
AI
changed the title
[WIP] Add second placeholder to duplicate display names error message
Add second placeholder to duplicate display names error message
Jan 8, 2026
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-river-093197403-3092.westeurope.5.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed format string parameter mismatch in
TfsUserMappingTool.cswhere the log message had one placeholder but two parameters were being passed.Changes
{accountName}placeholder to the error message format string inTfsUserMappingTool::GetUsersInSourceMappedToTargetMultiple target users found with the same display name '{displayName}' (account: {accountName}). Consider enabling MatchUsersByEmail option to avoid this issue.Before:
After:
Things to be aware of
"My message that contains {item} and {item2}", item, item2! Do not use$"My message that contains {item} and {item2}"to pass text into the log strings as this disables Serilog's ability to pass that data as telemetry to Application Insights and for log highlighting.Type of change
How Has This Been Tested?
Checklist:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.