Request Field Casing #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge to master
This commit introduces significant improvements to how JSON property names are managed and serialized across the application. Key changes include the addition of the Newtonsoft.Json namespace to enhance JSON serialization capabilities. The `JsonProperty` attribute is now utilized in `Listing.cs` to customize the serialization name of the `Place` property to `"placeCoordinates"`, ensuring alignment with external API or data storage formats. Furthermore, `AzureSearchMapping.cs` has been updated to leverage the `JsonPropertyAttribute` for more accurate and flexible property name mapping. This is complemented by the refactoring of `AzureSearchFieldsExpressionVisitor.cs`, which now uses the `NameHelper.GetMemberName` method for consistent field naming, abstracting away direct name manipulation. The introduction of the `NameHelper` utility class centralizes the logic for resolving member names, supporting both explicit naming through `JsonProperty` attributes and default camel casing. This utility is also employed in `MemberProjectionExpressionVisitor.cs` to maintain naming consistency across the application. Overall, these changes significantly enhance the flexibility and consistency of JSON property naming within the application, promoting better maintainability and code reuse.
nkovacic
reviewed
Jul 24, 2024
Owner
nkovacic
left a comment
nkovacic
left a comment
There was a problem hiding this comment.
Seeing only formatting issues, otherwise great 👍.
Author
|
@nkovacic, could we merge and release this? Let me know if there is anything I can do to help. |
Author
|
Bumping this up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to use the json.net's Json Property Attribute to map to the correct Azure search index fields.
#9