Dns refactor [Work in progress do not merge] #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dns decoding.
NOTE: At this time this pull request is not at feature parody with master. ToString functions are not as well developed. And while the name decode is simpler it is incomplete as it does not support use of pointers in dns names. This can not be merged in till both of those issues are addressed.
Sources:
https://tools.ietf.org/html/rfc1035 Section 4.1.4 has a good description of what makes a valid name
https://www.ietf.org/rfc/rfc1034.txt provides an intro to dns
SkypeIRC.cap contains several good examples of dns