fixup! http: improve performance by removing async_hooks

Author: JonasBa

lib/_http_server.js

@@ -996,7 +996,7 @@ function resOnFinish(req, res, socket, state, server) {
   // If the user never called req.read(), and didn't pipe() or
   // .resume() or .on('data'), then we call req._dump() so that the
   // bytes will be pulled off the wire.
-  if (!req._consuming && !req._readableState.resumeScheduled)
+  if (!req._consuming && !req._readableState.resumeScheduled && !req._readableState.paused)
     req._dump();
 
   res.detachSocket(socket);

src/node_http_parser.cc

@@ -464,10 +464,10 @@ class Parser : public BaseObject, public StreamListener {
 
     Local<Value> buffer = Buffer::Copy(env, at, length).ToLocalChecked();
 
-    MaybeLocal<Value> r =
-        cb.As<Function>()->Call(env->context(), object(), 1, &buffer);
+    v8::TryCatch try_catch(env->isolate());
+    USE(cb.As<Function>()->Call(env->context(), object(), 1, &buffer));
 
-    if (r.IsEmpty()) {
+    if (try_catch.HasCaught()) {
       got_exception_ = true;
       llhttp_set_error_reason(&parser_, "HPE_JS_EXCEPTION:JS Exception");
       return HPE_USER;
@@ -503,9 +503,11 @@ class Parser : public BaseObject, public StreamListener {
     if (!cb->IsFunction())
       return 0;
 
-    MaybeLocal<Value> r =
-        cb.As<Function>()->Call(env()->context(), object(), 0, nullptr);
-    if (r.IsEmpty()) {
+
+    v8::TryCatch try_catch(env()->isolate());
+    USE(cb.As<Function>()->Call(env()->context(), object(), 0, nullptr));
+
+    if (try_catch.HasCaught()) {
       got_exception_ = true;
       return -1;
     }
@@ -782,8 +784,14 @@ class Parser : public BaseObject, public StreamListener {
     current_buffer_len_ = nread;
     current_buffer_data_ = buf.base;
 
+    v8::TryCatch try_catch(env()->isolate());
     USE(cb.As<Function>()->Call(env()->context(), object(), 1, &ret));
 
+    if (try_catch.HasCaught()) {
+      got_exception_ = true;
+      return;
+    }
+
     current_buffer_len_ = 0;
     current_buffer_data_ = nullptr;
   }
@@ -897,10 +905,12 @@ class Parser : public BaseObject, public StreamListener {
       url_.ToString(env())
     };
 
-    if (cb.As<Function>()
-            ->Call(env()->context(), object(), arraysize(argv), argv)
-            .IsEmpty())
+    v8::TryCatch try_catch(env()->isolate());
+    USE(cb.As<Function>()->Call(env()->context(), object(), arraysize(argv), argv));
+
+    if (try_catch.HasCaught()) {
       got_exception_ = true;
+    }
 
     url_.Reset();
     have_flushed_ = true;

test/parallel/test-http-parser.js

@@ -518,14 +518,6 @@ function expectBody(expected) {
     '0\r\n'
   );
 
-  const req2 = Buffer.from(
-    'POST /that HTTP/1.0\r\n' +
-    'Content-Type: text/plain\r\n' +
-    'Content-Length: 4\r\n' +
-    '\r\n' +
-    'pong'
-  );
-
   const onHeadersComplete1 = (versionMajor, versionMinor, headers,
                               method, url) => {
     assert.strictEqual(method, methods.indexOf('PUT'));
@@ -537,18 +529,6 @@ function expectBody(expected) {
       ['Content-Type', 'text/plain', 'Transfer-Encoding', 'chunked']);
   };
 
-  const onHeadersComplete2 = (versionMajor, versionMinor, headers,
-                              method, url) => {
-    assert.strictEqual(method, methods.indexOf('POST'));
-    assert.strictEqual(url, '/that');
-    assert.strictEqual(versionMajor, 1);
-    assert.strictEqual(versionMinor, 0);
-    assert.deepStrictEqual(
-      headers,
-      ['Content-Type', 'text/plain', 'Content-Length', '4']
-    );
-  };
-
   const parser = newParser(REQUEST);
   parser[kOnHeadersComplete] = onHeadersComplete1;
   parser[kOnBody] = expectBody('ping');