lib: Attempted to fix issue #57780, child_process.js #57956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
MaxwellVanHoeij
changed the title
aduh95
reviewed
Apr 21, 2025
Comment on lines
+1
to
+5
| { | ||
| "dependencies": { | ||
| "iconv-lite": "^0.6.3" | ||
| } | ||
| } |
There was a problem hiding this comment.
As you can imagine, we're not going to want to have this file
aduh95
reviewed
Apr 21, 2025
Comment on lines
+23
to
+24
| } else { | ||
| // macOS: Test UTF-8 in bash |
There was a problem hiding this comment.
There are many more OSes which are neither Windows nor macOS
aduh95
reviewed
Apr 21, 2025
Comment on lines
+102
to
+103
| // Enhanced ChildProcess class with Windows encoding support | ||
| class ChildProcess extends OriginalChildProcess { |
There was a problem hiding this comment.
Introducing a class just to "highjack" spawnings of cmd.exe on Windows doesn't feel right – it's unclear whether we'd want to fix #57780 in the first place tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #57780