-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
src: use ranges library (C++20) to simplify code #57975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src: use ranges library (C++20) to simplify code ⚠ - breaking long lines ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14598958420 |
Looks like a missing
|
@richardlau good catch. |
@lemire It seems it doesn't build on any platforms at all |
It should build. Let us find out what the issue is. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57975 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.02%
==========================================
Files 630 630
Lines 186169 186169
Branches 36479 36479
==========================================
- Hits 168082 168062 -20
- Misses 10971 10974 +3
- Partials 7116 7133 +17
🚀 New features to boost your workflow:
|
@anonrig I am unhappy with the formatting of the code, but it works now !!!!!!!!! |
This PR uses C++20 ranges to slightly simplify a piece of code. To be honest, the real motivation of this PR is to introduce ranges and test whether the platforms play nice with ranges. If so, then this could be generalized in the code base.