doc,build,win: update docs with clang #57991
Open
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated BUILDING.md to make ClangCL mandatory for new versions of Node. Forcing clang-cl flag in vcbuild if not specified, thus disabling MSVC.
StefanStojanovic
added
doc
nodejs-github-bot
added
needs-ci
richardlau
added
dont-land-on-v18.x
richardlau
approved these changes
Apr 23, 2025
joyeecheung
approved these changes
Apr 23, 2025
lpinca
approved these changes
Apr 23, 2025
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
approved these changes
Apr 24, 2025
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the documentation to fit the new compiler on Windows - ClangCL. The main focus is the
BUILDING.mdfile. All threeWindows Prerequisitessections are updated to reflect the compiler change (WinGet configuration already supported it, so no changes there).In addition, there are changes to
vcbuild.batto add theclang-clflag for Node.js v24+ even if not provided. Since v24 will include #57753 (or some other V8 update), compiling with MSVC will result in errors, so IMHO, there is not much use in allowing MSVC compilation at all, although I'm open to suggestions and different opinions on this.