Skip to content

[v20.x] tools: update sccache version to v0.10.0 #57994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v20.x-staging
Choose a base branch
from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Apr 23, 2025

The update in 29c0324 was overwritten by d45517c.

Also this line breaks the test 29c0324#diff-9e078b64804cbda5c87567835a5da2f1314788813ec5c5e9809a2f96519b9b01R99
not sure why it worked during the release 🤔

@nodejs/releasers

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Apr 23, 2025
@aduh95
Copy link
Contributor

aduh95 commented Apr 23, 2025

not sure why it worked during the release 🤔

No GHA tests were run on the release commit, only Jenkins. The failure on the previous commit were ignored I guess

@marco-ippolito
Copy link
Member Author

I dont see test-linux being run but I think its important to run it 🤔

@richardlau
Copy link
Member

I dont see test-linux being run but I think its important to run it 🤔

It's not run because this PR hasn't changed any paths not ignored by:

pull_request:
paths-ignore:
- README.md
- .github/**
- '!.github/workflows/test-linux.yml'
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
paths-ignore:
- README.md
- .github/**
- '!.github/workflows/test-linux.yml'

@aduh95
Copy link
Contributor

aduh95 commented Apr 24, 2025

I dont see test-linux being run but I think its important to run it 🤔

Both commits are unrelated to test-linux though, why would you expect it to have any impact on it?

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Apr 24, 2025

I have the feeling the test is broken too due to the folder with weird chars tests being added, maybe I can run it manually ?

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Apr 24, 2025

Yeah test-linux is broken too, Ill fix the change that broke it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants