-
-
Couldn't load subscription status.
- Fork 33.6k
docs(perf_hooks): fix eventLoopUtilization examples to use performanc… #60421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(perf_hooks): fix eventLoopUtilization examples to use performanc… #60421
Conversation
|
There are conflicts that must be resolved |
|
Thank you for the feedback! I’ve resolved the merge conflicts and updated the documentation accordingly. |
|
thanks! I’ve resolved the conflicts and added the Node.js browser note as suggested. The section now correctly uses performance.eventLoopUtilization() and includes the note. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out! I removed this file because it appeared to be obsolete after syncing with the updated V8 tests. However, if it’s still required for regression coverage, I can restore it in the next commit. Please confirm your preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc of performance.eventLoopUtilization was intentionally moved to https://github.com/nodejs/node/blob/main/doc/api/perf_hooks.md#perf_hookseventlooputilizationutilization1-utilization2.
The performance.eventLoopUtilization is now an alias of perf_hooks.eventLoopUtilization.
…e object
docs(perf_hooks): fix eventLoopUtilization examples to use performance object
Summary
This PR fixes the examples for
eventLoopUtilization()in theperf_hooksdocumentation.Problem
The current documentation incorrectly shows: