tools: pin OpenSSL to 3.5.4 on test-shared workflow #60428
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
aduh95
added
dont-land-on-v20.x
aduh95
force-pushed
the
pin-openssl-shared
branch
from
cbb4bfa to
b6fe865
Compare
aduh95
force-pushed
the
pin-openssl-shared
branch
from
b6fe865 to
3d78c6f
Compare
add note in docs
cjihrig
approved these changes
Oct 27, 2025
aduh95
added
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #60088, we cannot yet test with OpenSSL 3.6.0. Pinning to unblock #60315.
Also adding
cachix/cachix-actionso we don't need to build OpenSSL every time. PRs from forks won't have access to the secret, but that's on purpose, so they can benefit from the read-only cache, but cannot do any cache poisoning.