Skip to content

tools: skip running test-shared on deps changes #60433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: skip running test-shared on deps changes #60433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/test-shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@ on:
- .mailmap
- '**.md'
- AUTHORS
- deps/ada/**
- deps/brotli/**
- deps/cares/**
- deps/corepack/**
- deps/icu-small/**
- deps/icu-tmp/**
- deps/llhttp/**
- deps/nghttp2/**
- deps/ngtcp2/**
Copy link
Member

@legendecas legendecas Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm is not a shared library but it is not bundled into node binary as well.

Suggested change
- deps/ngtcp2/**
- deps/ngtcp2/**
- deps/npm/**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wouldn't it be better to still check npm still works when Node.js is built with shared libraries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way, both of you are making valid points

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legendecas can you clarify whether this is a blocking concern?

- deps/openssl/*/**
- deps/simdjson/**
- deps/sqlite/**
- deps/uv/**
- deps/uvwasi/**
- deps/zlib/**
- deps/zstd/**
- doc/**
- .github/**
- '!.github/workflows/test-shared.yml'
Expand All @@ -20,6 +36,22 @@ on:
- .mailmap
- '**.md'
- AUTHORS
- deps/ada/**
- deps/brotli/**
- deps/cares/**
- deps/corepack/**
- deps/icu-small/**
- deps/icu-tmp/**
- deps/llhttp/**
- deps/nghttp2/**
- deps/ngtcp2/**
- deps/openssl/*/**
- deps/simdjson/**
- deps/sqlite/**
- deps/uv/**
- deps/uvwasi/**
- deps/zlib/**
- deps/zstd/**
- doc/**
- .github/**
- '!.github/workflows/test-shared.yml'
Expand Down