http: fix drain event with cork/uncork in ServerResponse #60437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60432
When using
cork()anduncork()withServerResponse, thedrainevent was not reliably emitted after uncorking. This occurred because theuncork()method did not check if a drain was pending (kNeedDrainflag) after flushing the chunked buffer.The Problem:
write()buffers data inkChunkedBufferinstead of sending immediatelywrite()returnsfalse,kNeedDrainis set totrueuncork()is called, it flushes the buffer by calling_send()uncork()never checked if drain was needed or emitted the eventdrainevent that would never fireThe Fix:
This commit ensures that when
uncork()successfully flushes buffered data and a drain was needed, thedrainevent is emitted immediately.Changes:
OutgoingMessage.prototype.uncork()inlib/_http_outgoing.js_send()calldrainevent when appropriateTesting:
The issue could be reproduced by using
cork()with multiple large writes and checking fordrainevents. With this fix, thedrainevent now fires correctly afteruncork().