Skip to content

Commit ee52ede

Browse files
committed
fix i18n aria-label text
1 parent d47d496 commit ee52ede

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

apps/site/components/withNavBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ const WithNavBar: FC = () => {
4141

4242
const themeToggleAriaLabel =
4343
resolvedTheme === 'dark'
44-
? t('components.common.themeToggle.label.light')
45-
: t('components.common.themeToggle.label.dark');
44+
? t('components.common.themeToggle.light')
45+
: t('components.common.themeToggle.dark');
4646

4747
const changeLanguage = (locale: SimpleLocaleConfig) =>
4848
replace(pathname!, { locale: locale.code });

apps/site/tests/e2e/general-behavior.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { importLocale } from '@node-core/website-i18n';
22
import type { Locale } from '@node-core/website-i18n/types';
3-
import { test, expect, type Page } from '@playwright/test';
3+
import { test, expect } from '@playwright/test';
4+
import type { Page } from '@playwright/test';
45

56
const englishLocale = await importLocale('en');
67

@@ -14,7 +15,7 @@ const locators = {
1415
// Global UI controls
1516
languageDropdownName: englishLocale.components.common.languageDropdown.label,
1617
// default light theme
17-
themeToggleName: englishLocale.components.common.themeToggle.label.light,
18+
themeToggleName: englishLocale.components.common.themeToggle.light,
1819

1920
// Search components (from Orama library)
2021
searchButtonTag: 'orama-button',
@@ -75,7 +76,7 @@ test.describe('Node.js Website', () => {
7576
const initialTheme = await getTheme(page);
7677
const initialAriaLabel = await themeToggle.getAttribute('aria-label');
7778
expect(initialAriaLabel).toBe(
78-
englishLocale.components.common.themeToggle.label[initialTheme]
79+
englishLocale.components.common.themeToggle[initialTheme]
7980
);
8081

8182
await themeToggle.click();
@@ -87,7 +88,7 @@ test.describe('Node.js Website', () => {
8788
expect(['light', 'dark']).toContain(newTheme);
8889

8990
expect(newAriaLabel).toBe(
90-
englishLocale.components.common.themeToggle.label[newTheme]
91+
englishLocale.components.common.themeToggle[newTheme]
9192
);
9293
});
9394

packages/i18n/src/locales/en.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,10 +229,8 @@
229229
"label": "Choose Language"
230230
},
231231
"themeToggle": {
232-
"label": {
233-
"light": "Toggle Light Mode",
234-
"dark": "Toggle Dark Mode"
235-
}
232+
"light": "Switch to Dark Mode",
233+
"dark": "Switch to Light Mode"
236234
}
237235
},
238236
"metabar": {

0 commit comments

Comments
 (0)