Skip to content

fix(playwright): increase fetch depth #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

avivkeller
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 3, 2025 13:56
@avivkeller avivkeller requested a review from a team as a code owner June 3, 2025 13:56
Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 3, 2025 1:56pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflows for Playwright to fetch more commit history during checkout, ensuring plugins that rely on recent commit data work correctly.

  • Increase fetch-depth from the default 1 to 2 for Git checkout in both workflows.
  • Applies the same change to the main Playwright workflow and the Cloudflare Open Next workflow.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/playwright.yml Added fetch-depth: 2 under the checkout step
.github/workflows/playwright-cloudflare-open-next.yml Added fetch-depth: 2 under the checkout step

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (e29253b) to head (4b25833).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7832      +/-   ##
==========================================
- Coverage   75.47%   75.46%   -0.02%     
==========================================
  Files         101      101              
  Lines        8309     8309              
  Branches      218      218              
==========================================
- Hits         6271     6270       -1     
- Misses       2036     2037       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! That's work but I don't get why we need to increase fetch dep. I mean why limit as been reach.

@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2025

LGTM ! That's work but I don't get why we need to increase fetch dep. I mean why limit as been reach.

git fetch depth of 2 allows git to run comparisons; fetch dept: 1 is current commit, 2 is the bare minimum for git to be able to make a diff.

@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2025

BTW, @avivkeller feel free to fast track this, you have my +1.

@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Jun 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 4, 2025
@avivkeller avivkeller enabled auto-merge June 4, 2025 19:28
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 93 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit c757502 Jun 4, 2025
19 checks passed
@avivkeller avivkeller deleted the fix/playwright-fetch-depth branch June 4, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants