-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(playwright): increase fetch depth #7832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions workflows for Playwright to fetch more commit history during checkout, ensuring plugins that rely on recent commit data work correctly.
- Increase
fetch-depth
from the default 1 to 2 for Git checkout in both workflows. - Applies the same change to the main Playwright workflow and the Cloudflare Open Next workflow.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
.github/workflows/playwright.yml | Added fetch-depth: 2 under the checkout step |
.github/workflows/playwright-cloudflare-open-next.yml | Added fetch-depth: 2 under the checkout step |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7832 +/- ##
==========================================
- Coverage 75.47% 75.46% -0.02%
==========================================
Files 101 101
Lines 8309 8309
Branches 218 218
==========================================
- Hits 6271 6270 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! That's work but I don't get why we need to increase fetch dep. I mean why limit as been reach.
git fetch depth of 2 allows git to run comparisons; fetch dept: 1 is current commit, 2 is the bare minimum for git to be able to make a diff. |
BTW, @avivkeller feel free to fast track this, you have my +1. |
Lighthouse Results
|
Ref: #7830 (comment) (https://github.com/microsoft/playwright/blob/main/packages/playwright/src/plugins/gitCommitInfoPlugin.ts#L74)