-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
blog: add post-eol announcement #7838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7838 +/- ##
==========================================
- Coverage 75.49% 75.44% -0.05%
==========================================
Files 101 101
Lines 8309 8305 -4
Branches 218 218
==========================================
- Hits 6273 6266 -7
- Misses 2034 2037 +3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Claudio W. <cwunder@gnome.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! TSYM, Matteo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO images should be static file. like the rest of blog posts
Co-authored-by: Aviv Keller <me@aviv.sh> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
@mcollina it seems my suggestion broke deployments 😅, can you wrap it in quotes ( |
I think I fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Lighthouse Results
|
Signed-off-by: Claudio W. <cwunder@gnome.org>
@ovflowd this should not have landed. It was clearly noted for a date in the future. |
Also, images are not rendering |
Ref #7773 - this is my blog post proposal.
Thanks to @rginn and @kyliewd for the edits.