chore: remove version support link #8002
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "Version Support" link from the website footer as part of consolidating version-related information into more prominent locations across the site.
- Removes the "versionSupport" translation key from the English locale file
- Removes the "Version Support" navigation link from the footer configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/i18n/src/locales/en.json | Removes the "versionSupport" translation key |
| apps/site/navigation.json | Removes the version support link from footer navigation |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8002 +/- ##
==========================================
- Coverage 73.03% 73.03% -0.01%
==========================================
Files 95 95
Lines 8341 8337 -4
Branches 217 217
==========================================
- Hits 6092 6089 -3
+ Misses 2248 2247 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
I disagree; it's definitely still needed and should remain. |
|
Could you elaborate on that? We aren't removing the page, just removing it from the footer. Users can still go to the "Downloads" page, and select "Releases", or select "About" and select "Releases" |
Note that the current link was just going to About > Previous Releases. Not the EOL/ESP page. The button is highlighted already on Home, About, Blog Posts, Download pages, pretty much all relevant pages of the website. Being in the footer doesn't really matter IMO, and removing this link allows us to accomodate the version pills in small screens. Otherwise we need to update the designs for better breakpoints. |
|
I think it’s premature to remove this link until the new pages have been up long enough to figure out where traffic is coming from. |
There was a problem hiding this comment.
agree with jordan - let's slow down a bit and let #7990 land first
I also think there are merits to keeping some sort of EOL information in the header or footer...as nothing in our navigation currently links to it (even in 7990)
With the work on #7906 and our EOL and ESP program links becoming prominent in multiple pages (downloads, about, home, security blog posts, etc) the need for a dedicated "version support" (which isn't clear IMO) isn't needed anymore.