Skip to content

chore: bump minimum required node version to 22.14.0 #8005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

dario-piotrowicz
Copy link
Member

Description

Very minor, but I just noticed that nvm is suggesting node 22, when trying to use a version of node >= 22 but < 22.14.0 results in errors when running commands such as pnpm dev and pnpm build due to the fact that that the generate script uses the glob's exclude option as a pattern, but that's only available in >= 22.14.0 (https://nodejs.org/docs/latest-v22.x/api/fs.html#fspromisesglobpattern-options). So I figured it'd be more correct to bump the required node version 🙂

Validation

I've manually validated that on my machine

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 21:39
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner July 21, 2025 21:39
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 21, 2025 9:41pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum required Node.js version from v22 to v22.14.0 to address compatibility issues with the glob API's exclude option functionality used in the project's generate script.

  • Updates the devEngines runtime version specification in package.json
  • Updates the .nvmrc file to pin to the specific Node.js version

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updates devEngines runtime version requirement from "v22" to ">=v22.14.0"
.nvmrc Updates Node version from "v22" to "v22.14.0" for nvm compatibility

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.92%. Comparing base (0122397) to head (00e91fc).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8005      +/-   ##
==========================================
- Coverage   72.97%   72.92%   -0.05%     
==========================================
  Files          95       95              
  Lines        8308     8308              
  Branches      214      215       +1     
==========================================
- Hits         6063     6059       -4     
- Misses       2244     2248       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjohansebas bjohansebas requested a review from a team July 21, 2025 23:11
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if .nvmrc should have web-infra as a code owner

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Jul 24, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 81 🟢 100 🟢 100 🔴 66 🔗
/en/about 🟢 99 🟢 97 🟢 100 🔴 58 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🔴 61 🔗
/en/download 🟢 95 🟢 100 🟢 100 🔴 66 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🔴 69 🔗

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeesto mikeesto added this pull request to the merge queue Jul 24, 2025
Merged via the queue into nodejs:main with commit 230c564 Jul 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants