-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: bump minimum required node version to 22.14.0 #8005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the minimum required Node.js version from v22 to v22.14.0 to address compatibility issues with the glob API's exclude option functionality used in the project's generate script.
- Updates the devEngines runtime version specification in package.json
- Updates the .nvmrc file to pin to the specific Node.js version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
package.json | Updates devEngines runtime version requirement from "v22" to ">=v22.14.0" |
.nvmrc | Updates Node version from "v22" to "v22.14.0" for nvm compatibility |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8005 +/- ##
==========================================
- Coverage 72.97% 72.92% -0.05%
==========================================
Files 95 95
Lines 8308 8308
Branches 214 215 +1
==========================================
- Hits 6063 6059 -4
- Misses 2244 2248 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if .nvmrc should have web-infra as a code owner
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dario-piotrowicz
Description
Very minor, but I just noticed that nvm is suggesting node 22, when trying to use a version of node >= 22 but < 22.14.0 results in errors when running commands such as
pnpm dev
andpnpm build
due to the fact that that the generate script uses the glob's exclude option as a pattern, but that's only available in >= 22.14.0 (https://nodejs.org/docs/latest-v22.x/api/fs.html#fspromisesglobpattern-options). So I figured it'd be more correct to bump the required node version 🙂Validation
I've manually validated that on my machine
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.