Skip to content

fix(learn): use yarn main website #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

himself65
Copy link
Member

Description

https://yarnpkg.com (yarn 3/4) is different with https://yarnpkg.com/en (old yarn 1), I think we should use the latest version of yarn

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 08:31
@himself65 himself65 requested a review from a team as a code owner July 22, 2025 08:31
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 22, 2025 8:32am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Yarn link in the npm introduction documentation to point to the current Yarn website (https://yarnpkg.com) instead of the legacy Yarn 1 URL (https://yarnpkg.com/en/).

  • Updates the Yarn documentation link to reference the modern Yarn website

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.95%. Comparing base (2a2aa16) to head (b2c8420).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8007      +/-   ##
==========================================
- Coverage   72.99%   72.95%   -0.04%     
==========================================
  Files          95       95              
  Lines        8317     8317              
  Branches      214      215       +1     
==========================================
- Hits         6071     6068       -3     
- Misses       2245     2248       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himself65 himself65 enabled auto-merge July 22, 2025 10:09
@ovflowd
Copy link
Member

ovflowd commented Jul 22, 2025

Off-topic: But their new website is so weird and random I would never have thought it was a package manager.

@avivkeller avivkeller disabled auto-merge July 22, 2025 12:57
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
@ovflowd ovflowd enabled auto-merge July 23, 2025 12:56
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 100 🔴 66 🔗
/en/about 🟢 100 🟢 97 🟢 100 🔴 58 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 100 🔴 61 🔗
/en/download 🟢 95 🟢 100 🟢 100 🔴 66 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🔴 69 🔗

@ovflowd ovflowd added this pull request to the merge queue Jul 23, 2025
Merged via the queue into nodejs:main with commit 8cec766 Jul 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants