Skip to content

fix: redirect Linux x86 download links to x64 binaries #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

adi-ray
Copy link

@adi-ray adi-ray commented Jul 22, 2025

Description

Fix broken Linux x86 download links by redirecting them to x64 binaries. The Node.js website was generating non-existent download URLs for Linux x86 architecture because Node.js v22+ no longer provides 32-bit Linux binaries. This fix ensures users on Android Chrome and other configurations that detect x86 architecture will receive working download links.

Validation

  • Manual Testing: Verified that Linux x86 platform detection now generates URLs pointing to existing x64 binaries
  • URL Verification: Confirmed generated URLs like https://nodejs.org/dist/v22.14.0/node-v22.14.0-linux-x64.tar.xz exist in the Node.js distribution
  • Cross-platform Testing: Ensured Windows x86, macOS, and ARM platforms remain unaffected
  • Reviewers should check: The Linux case in getNodeDownloadUrl() now includes fallback logic that converts x86 to x64 for Linux downloads only

Related Issues

Fixes #7589

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@adi-ray adi-ray requested a review from a team as a code owner July 22, 2025 14:25
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 22, 2025 2:26pm

@AugustinMauroy
Copy link
Member

@nodejs/releasers confirm that's correct maybe you have a link to include in comment

@ovflowd
Copy link
Member

ovflowd commented Jul 23, 2025

Unable to reproduce; PR description seems AI generated. Closing.

@ovflowd ovflowd closed this Jul 23, 2025
@adi-ray
Copy link
Author

adi-ray commented Jul 23, 2025

Unable to reproduce; PR description seems AI generated. Closing.

Reference issues: #7669 #7589

@ovflowd
Copy link
Member

ovflowd commented Jul 23, 2025

Unable to reproduce; PR description seems AI generated. Closing.

Reference issues: #7669 #7589

Noted, but this issue unfortunately not existent anymore since we removed the download button from the Homepage (which was the one impacted by this bug)

Since the downloads page, explicitly has a different set of constraints, that issue won't happen on the downloads page.

I appreciate the effort put in here, nevertheless!

(Also even though I mentioned the issue description is generated, that wasn't a factor of me closing the PR, just the unable to reproduce)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link on Downloading Node.js
6 participants