Skip to content

Conversation

@malav2110
Copy link
Contributor

Description

This PR fixes accessibility issue in the PartnerIcon component.

Validation

Before - Axe accessibility report:

Screenshot 2025-12-29 at 4 52 54 PM

After - Axe accessibility report:

Screenshot 2025-12-29 at 4 52 33 PM

Related Issues

fixes - #8466

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@malav2110 malav2110 requested a review from a team as a code owner December 29, 2025 23:57
Copilot AI review requested due to automatic review settings December 29, 2025 23:57
@vercel
Copy link

vercel bot commented Dec 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Dec 30, 2025 0:07am

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes accessibility issues in the PartnerIcon component by adding aria-label attributes to partner buttons and configuring the Tooltip component to properly merge props with its children using the asChild prop.

  • Adds asChild prop to Tooltip wrapper to enable proper prop forwarding
  • Adds aria-label attributes to provide accessible names for partner links
  • Reformats PartnerButton props for better readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🙇

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 30, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 96 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 93 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.73%. Comparing base (587fe94) to head (0d2da57).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8489      +/-   ##
==========================================
+ Coverage   73.69%   73.73%   +0.04%     
==========================================
  Files         108      108              
  Lines        9210     9210              
  Branches      313      312       -1     
==========================================
+ Hits         6787     6791       +4     
+ Misses       2421     2417       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants