-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: PartnerIcon Accessibility #8489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes accessibility issues in the PartnerIcon component by adding aria-label attributes to partner buttons and configuring the Tooltip component to properly merge props with its children using the asChild prop.
- Adds
asChildprop to Tooltip wrapper to enable proper prop forwarding - Adds
aria-labelattributes to provide accessible names for partner links - Reformats PartnerButton props for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM 🙇
|
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8489 +/- ##
==========================================
+ Coverage 73.69% 73.73% +0.04%
==========================================
Files 108 108
Lines 9210 9210
Branches 313 312 -1
==========================================
+ Hits 6787 6791 +4
+ Misses 2421 2417 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
canerakdas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for the contribution 🎉
Description
This PR fixes accessibility issue in the
PartnerIconcomponent.Validation
Before - Axe accessibility report:
After - Axe accessibility report:
Related Issues
fixes - #8466
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.