feat(mdx): move to dedicated package, switch to @next/mdx #8490
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
avivkeller
force-pushed
the
test/mdx-migration
branch
from
9551c61 to
e64f5af
Compare
|
I'm aware reviewing this many files is impossible. Once I get everything passing, I will make this much more manageable. Right now, the goal was just to be in a position where a feature branch could be opened |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8490 +/- ##
==========================================
- Coverage 73.73% 73.56% -0.17%
==========================================
Files 108 107 -1
Lines 9210 9140 -70
Branches 312 307 -5
==========================================
- Hits 6791 6724 -67
+ Misses 2417 2414 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
casual tuesday 1am (cest): claudio about to chill with YouTube |
|
I think you might wanna go back to that YouTube... this is no where near ready 😅. On the silver lining, through the process of building this, I have several bug reports to send to Next.js. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (16)
➖ Removed Assets (16)
|
😲I'm still figuring out where this is a good thing or a bad thing :/ |
Imma gonna back to another lifetime 😆 -- Im out! HAHAHA |
🌡️ |
avivkeller
force-pushed
the
test/mdx-migration
branch
from
604cbc4 to
4f7c07e
Compare
avivkeller
force-pushed
the
test/mdx-migration
branch
from
4f7c07e to
8005acf
Compare
|
|
If I can get it to work, we should see a substantial size reduction on both the client and server build.... if I can get it to work |
This is a really early draft. We had a bit of extra time after last week's monthly meeting, so we discussed the potential move from our custom MDX logic to
@next/mdx. This PR isn't a "we are moving!", it's a brainstorming PR so see what that kind of change would look like...In order to do so, a few things must be done:
pages/directory cannot be used, as Next.js will assume it's part of the pages routercrowdin.yml)mdx, else they will not properly be imported by Next.jsrequire.resolveinstead of just importing)TODO:
Note:
All markdown files were moved in 0ad73d6, and everything else is 8005acf-post.