Skip to content

Commit 7483524

Browse files
committed
Merge branch 'dev'
2 parents c8a67d7 + 357d65a commit 7483524

File tree

7 files changed

+95
-5
lines changed

7 files changed

+95
-5
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ pnpm tauri build
3636

3737
Then find the exe in `\src-tauri\target\release\`
3838

39+
## Notes
40+
41+
If you know how to get the package versions for a specific unity template, please let me know. Things like the built-in package somehow
42+
have updated package versions that aren't the recommended version, but aren't the versions in their template file anywhere.
43+
3944
## FAQ
4045

4146
### Why does my local package.json file keeps failing to be read?

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "nomnom-unity-hub",
33
"private": true,
4-
"version": "1.0.6",
4+
"version": "1.0.7",
55
"type": "module",
66
"scripts": {
77
"dev": "vite",
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
using System.Linq;
2+
using UnityEditor;
3+
using UnityEditor.PackageManager;
4+
using UnityEngine;
5+
using UnityEngine.Pool;
6+
7+
public class PackageClientTest {
8+
[MenuItem("PackageClientTest/PerformCheck")]
9+
static void PerformCheck() {
10+
var installed = Client.List();
11+
while (!installed.IsCompleted) { }
12+
13+
if (installed.Error != null) {
14+
Debug.LogError(installed.Error);
15+
return;
16+
}
17+
18+
var packages = Client.SearchAll(false);
19+
while (!packages.IsCompleted) { }
20+
21+
if (packages.Error != null) {
22+
Debug.LogError(packages.Error);
23+
}
24+
else {
25+
using var _ = ListPool<string>.Get(out var toAdd);
26+
foreach (var package in packages.Result) {
27+
if (installed.Result.All(x => x.name != package.name)) continue;
28+
29+
Debug.Log($"{package.name}: {package.version} | latest: {package.versions.latest} | recommended: {package.versions.recommended}");
30+
toAdd.Add(package.name);
31+
}
32+
33+
var request = Client.AddAndRemove(toAdd.ToArray());
34+
}
35+
}
36+
}

src-tauri/src/editor.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,9 @@ pub fn open(
264264
.clone();
265265

266266
let exe_path = get_real_exe_path(&editor)?;
267+
268+
println!("Opening editor: {}", exe_path.display());
269+
println!("Arguments: {:?}", arguments);
267270

268271
if wait {
269272
std::process::Command::new(&exe_path)

src-tauri/src/generate.rs

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,52 @@ pub fn generate_project(app: &tauri::AppHandle, app_state: &tauri::State<'_, App
150150
std::fs::write(&package_lock_path, serde_json::to_string_pretty(&json_str)?)?;
151151
}
152152

153+
let project_settings_path = package_cache_dir_out
154+
.join("ProjectSettings")
155+
.join("ProjectSettings.asset");
156+
157+
if project_settings_path.is_file() {
158+
let project_settings = std::fs::read_to_string(&project_settings_path)?;
159+
let mut lines = project_settings.lines().map(|x| x.to_string()).collect::<Vec<_>>();
160+
161+
for line in lines.iter_mut() {
162+
let trimmed_line = line.trim();
163+
if trimmed_line.starts_with("companyName: ") {
164+
*line = " companyName: DefaultCompany".to_string();
165+
continue;
166+
}
167+
168+
if trimmed_line.starts_with("productName: ") {
169+
*line = format!(" productName: {}", project_info.name.clone());
170+
break;
171+
}
172+
}
173+
174+
let project_settings = lines.join("\n");
175+
std::fs::write(&project_settings_path, project_settings)?;
176+
}
177+
178+
// let out_path = package_cache_dir_out
179+
// .to_str()
180+
// .ok_or(errors::str_error("Failed to convert path to string"))?
181+
// .to_string();
182+
// println!("out path: {}", out_path);
183+
184+
// let embedded_cs_script = include_str!("assets/PackageClientTest.cs");
185+
// let embedded_cs_script_path = package_cache_dir_out
186+
// .join("Assets")
187+
// .join("PackageClientTest.cs");
188+
189+
// println!("writing script: {}", embedded_cs_script_path.display());
190+
// std::fs::write(&embedded_cs_script_path, embedded_cs_script)?;
191+
192+
// println!("running script: {}", embedded_cs_script_path.display());
193+
// crate::editor::open(template_info.editor_version.version.clone(), vec!["-quit".to_string(), "-batchmode".to_string(), "-projectPath".to_string(), format!("{}", out_path).to_string(), "-executeMethod".to_string(), "PackageClientTest.PerformCheck".to_string()], app_state, true)?;
194+
195+
// // delete script
196+
// println!("deleting script: {}", embedded_cs_script_path.display());
197+
// std::fs::remove_file(&embedded_cs_script_path)?;
198+
153199
// crate::project::update_project_open_time(app_state, package_cache_dir_out.clone(), app)?;
154200
// crate::project::cmd_open_project_in_editor(app.clone(), app_state.clone(), package_cache_dir_out.clone(), editor_version.clone())?;
155201

src-tauri/src/project.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,8 @@ pub fn cmd_is_open_in_editor(project_path: PathBuf, editor_version: String, app_
365365
.ok_or(errors::str_error("Invalid project path"))?
366366
.to_string();
367367

368+
let project_name = format!("{} - ", project_name);
369+
368370
// needs to start with project_name and contain Unity editor_version near the end
369371
// todo: make sure this works fine on other platforms
370372
let contains_title = titles

src-tauri/tauri.conf.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
},
88
"package": {
99
"productName": "Nomnoms Unity Hub",
10-
"version": "1.0.6"
10+
"version": "1.0.7"
1111
},
1212
"tauri": {
1313
"allowlist": {
@@ -33,9 +33,7 @@
3333
"http": {
3434
"all": true,
3535
"request": true,
36-
"scope": [
37-
"https://raw.githubusercontent.com/*"
38-
]
36+
"scope": ["https://raw.githubusercontent.com/*"]
3937
}
4038
},
4139
"windows": [

0 commit comments

Comments
 (0)