Merge pull request #9040 from achouhan09/temp-dir-fix

Added a fix to not include the temp dir in list objects

Author: achouhan09

src/sdk/namespace_fs.js

@@ -767,7 +767,7 @@ class NamespaceFS {
                     // dbg.log0('process_entry', dir_key, ent.name);
                     if (!ent.name.startsWith(prefix_ent) ||
                         ent.name < marker_curr ||
-                        ent.name === this.get_bucket_tmpdir_name() ||
+                        ent.name.startsWith(config.NSFS_TEMP_DIR_NAME) ||
                         (ent.name === config.NSFS_FOLDER_OBJECT_NAME && is_disabled_dir_content) ||
                         this._is_hidden_version_path(ent.name)) {
                         return;

src/test/unit_tests/test_ns_list_objects.js

@@ -3,8 +3,10 @@
 
 const mocha = require('mocha');
 const assert = require('assert');
+const config = require('../../../config');
 
 const buffer_utils = require('../../util/buffer_utils');
+const fs_utils = require('../../util/fs_utils');
 
 // eslint-disable-next-line max-lines-per-function
 function test_ns_list_objects(ns, object_sdk, bucket) {
@@ -313,6 +315,33 @@ function test_ns_list_objects(ns, object_sdk, bucket) {
         });
     });
 
+    mocha.describe('list objects - hidden dir', function() {
+
+        this.timeout(10 * 60 * 1000); // eslint-disable-line no-invalid-this
+
+        const hidden_dir_bkt = 'test_ns_hidder_dir';
+        const dummy_file1 = 'dummy1';
+        const dummy_file2 = 'dummy2';
+        const hidden_dir = config.NSFS_TEMP_DIR_NAME + '-buck_id';
+
+        mocha.before(async function() {
+            fs_utils.create_fresh_path(`${ns.bucket_path}/${hidden_dir}`); // creating new hidden dir starting with .noobaa-nsfs
+            await create_keys([dummy_file1, dummy_file2]);
+        });
+        mocha.after(async function() {
+            await delete_keys([dummy_file1, dummy_file2]);
+        });
+
+        mocha.it('should not list the hidden/internal dir as common_prefixes', async function() {
+            const r = await ns.list_objects({
+                bucket: hidden_dir_bkt,
+                delimiter: '/'
+            }, object_sdk);
+            assert.deepStrictEqual(r.is_truncated, false);
+            assert.deepStrictEqual(r.common_prefixes, []);
+            assert.deepStrictEqual(r.objects.length, 2);
+        });
+    });
     mocha.describe('max keys test', function() {
 
         this.timeout(10 * 60 * 1000); // eslint-disable-line no-invalid-this