NC | Lifecycle | GPFS | fix skip of incorrect noobaa uploads internal directory

[romayalon]

Describe the Problem

As part of code reviewing, I noticed we are skipping .noobaa_nsfs%/% directory instead of .noobaa-nsfs%/% directory during the nc lifecycle on GPFS flow. Although when setting empty prefix filter I couldn't make this directory get deleted using the lifecycle process.

Explain the Changes

1. changed to skip the correct internal uploads directory.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

• Doc added/updated
• Tests added

Summary by CodeRabbit

• Refactor

  • Updated internal directory path construction to use a configurable directory name instead of a hardcoded value for lifecycle policy generation.

• Tests

  • Adjusted tests to align with the new configurable directory name for temporary NSFS directories.

[coderabbitai]

Walkthrough

The changes update the construction of an internal directory path for GPFS ILM policy conversion in the lifecycle management code, replacing a hardcoded directory name with a configurable one. Corresponding unit tests are adjusted to use the same configuration variable for consistency. No public API or exported entity signatures are changed.

Changes

File(s)	Change Summary
src/manage_nsfs/nc_lifecycle.js	Replaces hardcoded internal directory name with a dynamic value from config.NSFS_TEMP_DIR_NAME.
src/test/unit_tests/jest_tests/test_nc_lifecycle_gpfs_ilm_integration.test.js	Updates test exclusion pattern to use the configuration variable instead of a hardcoded directory name.

Poem

A path once fixed, now takes its cue
From configs set by me or you.
Tests now follow, neat and spry,
No more hardcodes slipping by.
With every hop, our code grows strong—
Configurable, adaptable, hopping along!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-10T16_17_07_126Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19d7a5a and 96d0119.

📒 Files selected for processing (2)

• src/manage_nsfs/nc_lifecycle.js (1 hunks)
• src/test/unit_tests/jest_tests/test_nc_lifecycle_gpfs_ilm_integration.test.js (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/test/unit_tests/jest_tests/test_nc_lifecycle_gpfs_ilm_integration.test.js (2)

src/manage_nsfs/nc_lifecycle.js (6)

• config (10-10)
• require (13-13)
• require (15-15)
• require (19-19)
• require (20-20)
• require (23-24)

src/test/system_tests/test_utils.js (5)

• config (10-10)
• require (11-11)
• require (12-12)
• require (16-16)
• require (18-18)

🔇 Additional comments (2)

src/manage_nsfs/nc_lifecycle.js (1)

1213-1213: Excellent fix using configurable directory name!

This change correctly replaces the hardcoded directory name with config.NSFS_TEMP_DIR_NAME, which addresses the bug where the incorrect internal directory was being skipped during lifecycle processing. Using a configuration variable instead of hardcoded values is a best practice that improves maintainability.

src/test/unit_tests/jest_tests/test_nc_lifecycle_gpfs_ilm_integration.test.js (1)

9-9: Good addition of config import for consistency.

Adding the config import enables the test to use the same configuration variable as the implementation, ensuring consistency between the actual code and test mocks.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.