Skip to content

Bumping deps to avoid CVE (24/07/2025) #9157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Jul 24, 2025

Describe the Problem

  • Bumping deps to avoid CVE (24/07/2025)

Summary by CodeRabbit

  • Chores
    • Updated various AWS and Azure SDK dependencies to newer versions.
    • Upgraded several other dependencies and development tools to their latest patch or minor versions.

@liranmauda liranmauda requested a review from jackyalbo July 24, 2025 06:59
Copy link

coderabbitai bot commented Jul 24, 2025

"""

Walkthrough

This change updates multiple dependencies in the package.json file. AWS SDK, Azure SDK, and several other libraries received minor or patch version bumps. No source code, configuration, scripts, or exported/public entities were altered; only dependency versions were incremented.

Changes

File(s) Change Summary
package.json Updated AWS SDK packages (@aws-sdk/client-s3, @aws-sdk/client-sts, @aws-sdk/credential-providers, @aws-sdk/s3-request-presigner, @aws-sdk/client-iam, @aws-sdk/lib-storage), Azure SDK package (@azure/identity), and other dependencies (compression, morgan, nan, node-addon-api, TypeScript node types, Jest) to newer patch or minor versions. No changes to scripts or configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Bumping deps to avoid CVE (02/07/2025) #9129: Both PRs focus on updating dependency versions in package.json, specifically bumping AWS and Azure SDK packages along with other dependencies, without modifying any code or exported entities.

Suggested labels

size/M

Suggested reviewers

  • nimrod-becker
    """

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3938440 and 0c0fcca.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (4 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: run-jest-unit-tests
  • GitHub Check: Build Noobaa Image
  • GitHub Check: run-package-lock-validation
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2727e34 and 09112f3.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (4 hunks)
🔇 Additional comments (5)
package.json (5)

75-78: AWS SDK bumps look correct—run integration tests for coverage.

All four AWS modules jumped 8–10 patch versions within the same major line, so no breaking-change risk is expected.
Nevertheless, these packages are heavily relied upon across the codebase (S3 client, presigner, STS, credential providers). Please:

  1. Inspect their changelogs for deprecations or default-behaviour tweaks (e.g. retry mode, endpoint discovery).
  2. Execute the full test-suite and a smoke deploy against an S3/STS sandbox to ensure request signing and STS role-assume still work.

79-82: Azure SDK patch upgrades—verify minimum Node.js support hasn’t shifted.

@azure/identity@4.10.2 and @azure/storage-blob@12.28.0 are patch bumps, primarily CVE fixes. The Azure team occasionally bumps their minimum supported Node version in patches; confirm your current runtime (shown in Dockerfiles/CI) still satisfies the engine field.


90-90: compression 1.8.1 patches CVE-2024-4515—good catch.

Upgrade is desirable and low-risk; no action required.


128-135: Dev-dependency bumps—sync the lock-file.

@aws-sdk/* dev tools, @types/node, etc. all saw patch bumps. Ensure package-lock.json (or pnpm-lock.yaml) is regenerated and committed so CI environments install the exact versions.


139-139: Jest patched to 30.0.5—run the test matrix.

This patch fixed a couple of watch-mode regressions; no API changes reported. Run npm run jest locally to spot any latent failures before merging.

- Bumping deps to avoid CVE (24/07/2025)

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda merged commit 25db33f into noobaa:master Jul 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants