-
Notifications
You must be signed in to change notification settings - Fork 27
Common fix #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SlejmUr
wants to merge
9
commits into
northwood-studios:dev
Choose a base branch
from
SlejmUr:patch-1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Common fix #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brayden-dowson
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
I checked the base game and it reads the value back so no MR is needed.
|
I checking more of these going back to draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nitpick really
Co-authored-by: David <david.sebesta@post.cz>
LilNesquuik
pushed a commit
to LilNesquuik/LabAPI
that referenced
this pull request
Aug 14, 2025
LilNesquuik
pushed a commit
to LilNesquuik/LabAPI
that referenced
this pull request
Aug 14, 2025
* Adds throw propertly to Item EventsArgs (northwood-studios#246) * Added more properties to PlayerDeath event arg (northwood-studios#241) * Added OldRole to PlayerDeath event arg * docs * more properties * Apply suggestions from code review --------- Co-authored-by: Beryl <10091181+SebasCapo@users.noreply.github.com> * Adds attacker player to placed blood event (northwood-studios#239) * Playerscale + events (northwood-studios#244) * Scale * Added chaos and surface pass keycard to the keycard item register * Added CanOpen to UnlockingGenerator event Added Scp079Pinging/ed event Added RoundEndingConditionsCheck event Added permisisosn to the keycard wrapper * PingType to enum namespace * Ping to enum, comments * 1.1.0 Version Bump --------- Co-authored-by: brayden-dowson <88667957+brayden-dowson@users.noreply.github.com> Co-authored-by: Beryl <10091181+SebasCapo@users.noreply.github.com> Co-authored-by: David <david.sebesta@post.cz>
LilNesquuik
pushed a commit
to LilNesquuik/LabAPI
that referenced
this pull request
Aug 14, 2025
* Adds throw propertly to Item EventsArgs (northwood-studios#246) * Added more properties to PlayerDeath event arg (northwood-studios#241) * Added OldRole to PlayerDeath event arg * docs * more properties * Apply suggestions from code review --------- Co-authored-by: Beryl <10091181+SebasCapo@users.noreply.github.com> * Adds attacker player to placed blood event (northwood-studios#239) * Playerscale + events (northwood-studios#244) * Scale * Added chaos and surface pass keycard to the keycard item register * Added CanOpen to UnlockingGenerator event Added Scp079Pinging/ed event Added RoundEndingConditionsCheck event Added permisisosn to the keycard wrapper * PingType to enum namespace * Ping to enum, comments * 1.1.0 Version Bump --------- Co-authored-by: brayden-dowson <88667957+brayden-dowson@users.noreply.github.com> Co-authored-by: Beryl <10091181+SebasCapo@users.noreply.github.com> Co-authored-by: David <david.sebesta@post.cz>
Jesus-QC
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.