Skip to content

PluginCommunication: Footnotes for Arrays of Path Strings #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

pryrt
Copy link
Contributor

@pryrt pryrt commented Jan 1, 2025

Adds a description of the memory requirements for Arrays of Path Strings, and links to that from the wchar_t ** messages.
closes #748

(Also fix from the old TCHAR to wchar_t throughout the PluginCommunication, to match the recent Notepad_plus_msgs.h)

@pryrt
Copy link
Contributor Author

pryrt commented Jan 1, 2025

@alankilborn and @molsonkiko, how does this look? Each of the four wchar_t ** messages links to the footnote, and the footnote explains to use MAX_PATH wide characters, which is MAX_PATH*2 bytes.

@alankilborn
Copy link

Looks reasonable to me.

@molsonkiko
Copy link

@pryrt Yep, that looks like a reasonable change to me. Thanks!

@pryrt pryrt merged commit 9313a44 into notepad-plus-plus:master Jan 1, 2025
1 check passed
@pryrt pryrt deleted the nameArrays branch January 1, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPPM_GETOPENFILENAMES (and similar) Memory Allocation
3 participants