Skip to content

fix: Use the private value as long as it isn't undefined #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

owlstronaut
Copy link
Contributor

@owlstronaut owlstronaut commented May 2, 2025

Related: npm/cli#8246

@owlstronaut owlstronaut marked this pull request as ready for review May 2, 2025 16:15
@owlstronaut owlstronaut requested a review from a team as a code owner May 2, 2025 16:15
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra undefined checks were to prevent a breaking change.

@wraithgar wraithgar merged commit 23c5eb9 into main May 5, 2025
18 checks passed
@wraithgar wraithgar deleted the owlstronaut/init-private branch May 5, 2025 14:27
@github-actions github-actions bot mentioned this pull request May 5, 2025
wraithgar pushed a commit that referenced this pull request May 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[8.2.0](v8.1.1...v8.2.0)
(2025-05-05)
### Features
*
[`8f6d95d`](8f6d95d)
[#329](#329) add new test
packages (#329) (@wraithgar)
### Bug Fixes
*
[`23c5eb9`](23c5eb9)
[#327](#327) Use the
private value as long as it isn't undefined (#327) (@owlstronaut)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants