feat(core): generate AI files in create-nx-workspace #32442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MaxKless
force-pushed
the
ai-files-generation
branch
from
8715f7a to
65e4cb2
Compare
MaxKless
changed the title
MaxKless
force-pushed
the
ai-files-generation
branch
from
65e4cb2 to
7f328ca
Compare
|
View your CI Pipeline Execution ↗ for commit 5710028
☁️ Nx Cloud last updated this comment at |
MaxKless
force-pushed
the
ai-files-generation
branch
from
c0d176d to
34cc4f5
Compare
MaxKless
force-pushed
the
ai-files-generation
branch
from
a833914 to
762aea2
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32442-762aea2 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32442-762aea2
To request a new release for this pull request, mention someone from the Nx team or the |
MaxKless
requested review from
FrozenPandaz,
jaysoo,
AgentEnder,
a team,
vsavkin and
JamesHenry
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+27
to
+36
| try { | ||
| const getLatestGeneratorResult = await getLatestGeneratorUsingInstall( | ||
| normalizedOptions | ||
| ); | ||
| const { module: latestGeneratorModule, cleanup } = getLatestGeneratorResult; | ||
| const setupAiAgentsGeneratorResult = | ||
| await latestGeneratorModule.setupAiAgentsGeneratorImpl(tree, options); | ||
| await cleanup(); | ||
| return setupAiAgentsGeneratorResult; | ||
| } catch (error) { |
There was a problem hiding this comment.
There's a potential null reference issue in this code. The getLatestGeneratorUsingInstall function can return undefined, but the code immediately destructures the result without checking. If getLatestGeneratorResult is undefined, the line const { module: latestGeneratorModule, cleanup } = getLatestGeneratorResult; will throw a runtime error.
Consider adding a null check before destructuring:
const getLatestGeneratorResult = await getLatestGeneratorUsingInstall(normalizedOptions);
if (getLatestGeneratorResult) {
const { module: latestGeneratorModule, cleanup } = getLatestGeneratorResult;
const setupAiAgentsGeneratorResult =
await latestGeneratorModule.setupAiAgentsGeneratorImpl(tree, options);
await cleanup();
return setupAiAgentsGeneratorResult;
}
Suggested change
| try { | |
| const getLatestGeneratorResult = await getLatestGeneratorUsingInstall( | |
| normalizedOptions | |
| ); | |
| const { module: latestGeneratorModule, cleanup } = getLatestGeneratorResult; | |
| const setupAiAgentsGeneratorResult = | |
| await latestGeneratorModule.setupAiAgentsGeneratorImpl(tree, options); | |
| await cleanup(); | |
| return setupAiAgentsGeneratorResult; | |
| } catch (error) { | |
| try { | |
| const getLatestGeneratorResult = await getLatestGeneratorUsingInstall( | |
| normalizedOptions | |
| ); | |
| if (getLatestGeneratorResult) { | |
| const { module: latestGeneratorModule, cleanup } = getLatestGeneratorResult; | |
| const setupAiAgentsGeneratorResult = | |
| await latestGeneratorModule.setupAiAgentsGeneratorImpl(tree, options); | |
| await cleanup(); | |
| return setupAiAgentsGeneratorResult; | |
| } | |
| } catch (error) { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
- Remove unused import for non-existent add-mcp-to-codex-config module - Fix setup-ai-agents generator paths from dist to src - Add required schema description for setup-ai-agents generator
FrozenPandaz
force-pushed
the
ai-files-generation
branch
from
6b5cf77 to
e8b491e
Compare
MaxKless
added
the
PR status: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new generator to automatically set up AI agent configuration files and Nx MCP server integration when creating a new Nx workspace. It ensures that guidelines and configuration for common AI assistants (Claude and Gemini) are included by default, improving developer experience and AI integration. The changes also update documentation to reflect these enhancements.
AI Agent Setup and Integration
set-up-ai-agents, topackages/workspace/generators.jsonthat generates configuration files (CLAUDE.md,GEMINI.md,.mcp.json, and.gemini/settings.json) with guidelines and Nx MCP server settings for AI assistants. [1] [2] [3] [4] [5]setupAiAgentsGeneratoringenerate-workspace-files.ts, ensuring these files are created for every new workspace. [1] [2]Documentation Updates
astro-docsand shared docs to mention the inclusion of AI agent configuration files (CLAUDE.md,GEMINI.md) during workspace creation. [1] [2]Internal Improvements
These changes collectively streamline AI assistant onboarding for Nx users and ensure that new workspaces are ready for advanced AI-powered development workflows.