-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(react-native): fix nightly #32507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit 27bd51f
☁️ Nx Cloud last updated this comment at |
973d7ca
to
6f2124c
Compare
6f2124c
to
3dc1e36
Compare
3dc1e36
to
ca316f9
Compare
ca316f9
to
8b62937
Compare
8b62937
to
27bd51f
Compare
@claude Could you write a PR description for this PR please? |
Claude finished @FrozenPandaz's task —— View job I'll write a PR description for this React Native nightly fix. Todo List
PR DescriptionCurrent BehaviorThe React Native e2e tests contain variable naming conflicts and inconsistent error handling in the process cleanup sections:
Expected BehaviorThe React Native e2e tests should have:
Changes Made
This fixes issues that could occur in nightly builds where process cleanup wasn't being handled consistently, potentially leading to hanging processes or ports. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The React Native e2e tests contain variable naming conflicts and inconsistent error handling in the process cleanup sections:
process
shadow the global Node.jsprocess
objectExpected Behavior
The React Native e2e tests should have:
Changes Made
process
variables tochildProcess
to avoid shadowing the global Node.jsprocess
objectundefined
for process ID when the process reference is not available, allowingkillProcessAndPorts
to handle port cleanup appropriatelyThis fixes issues that could occur in nightly builds where process cleanup wasn't being handled consistently, potentially leading to hanging processes or ports.