Skip to content

chore(repo): limit pr validation runs to checkout only from master #32545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2025
Merged

chore(repo): limit pr validation runs to checkout only from master #32545

merged 2 commits into from
Aug 29, 2025
+5 −3

Conversation

AgentEnder
Copy link
Member

Reduces some unnecessary permissions to ease future risks.

@AgentEnder AgentEnder requested a review from a team as a code owner August 27, 2025 19:25
@AgentEnder AgentEnder requested a review from meeroslav August 27, 2025 19:25
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Aug 29, 2025 5:02pm

@nx-cloud Nx Cloud
Copy link
Contributor

nx-cloud bot commented Aug 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6bcf1bd

Command Status Duration Result
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 37s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded <1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-29 16:49:21 UTC

FrozenPandaz
FrozenPandaz requested changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 # For pull_request_target, we need to checkout the base branch

This is not true anymore right?

@AgentEnder AgentEnder force-pushed the chore/limit-validation-runs branch from edc66ae to 2c5342c Compare August 29, 2025 16:35
@AgentEnder AgentEnder force-pushed the chore/limit-validation-runs branch from 2c5342c to 6bcf1bd Compare August 29, 2025 16:38
@FrozenPandaz FrozenPandaz changed the title chore(repo): limit pr validation runs to prs targetting master chore(repo): limit pr validation runs to checkout only from master Aug 29, 2025
@AgentEnder AgentEnder merged commit 0560433 into master Aug 29, 2025
18 of 19 checks passed
@AgentEnder AgentEnder deleted the chore/limit-validation-runs branch August 29, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner automatically assigned from nrwl/nx-pipelines-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgentEnder @FrozenPandaz