Skip to content

Conversation

leosvelperez
Copy link
Member

Current Behavior

The TUI tasks list uses pagination when it has many tasks that don't fit in the viewport.

Expected Behavior

The TUI tasks list should be scrollable and not use pagination.

Additionally, this PR includes a fix so that when a task is selected in the task list, it's always ensured that the task is visible if resizing the terminal or when the task is moved due to a different status.

@leosvelperez leosvelperez self-assigned this Aug 28, 2025
@leosvelperez leosvelperez requested review from a team as code owners August 28, 2025 17:59
Copy link

vercel bot commented Aug 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 5, 2025 7:49am

Copy link
Contributor

nx-cloud bot commented Aug 28, 2025

View your CI Pipeline Execution ↗ for commit b2acfb7

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 25m 6s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 25s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 2m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-05 12:33:32 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We fixed the e2e test failures by modifying the Playwright installation logic to avoid the --with-deps flag in CI environments. This prevents apt package manager lock conflicts that were causing the tests to fail when multiple processes tried to install system dependencies simultaneously.

We could not verify this fix.

diff --git a/e2e/utils/get-env-info.ts b/e2e/utils/get-env-info.ts
index 20173dd..ce5038f 100644
--- a/e2e/utils/get-env-info.ts
+++ b/e2e/utils/get-env-info.ts
@@ -178,8 +178,10 @@ export function ensurePlaywrightBrowsersInstallation() {
   }
 
   // Only install browsers for local development
+  // In CI environments, avoid --with-deps to prevent apt lock conflicts
+  const defaultArgs = process.env.CI ? '' : '--with-deps';
   const playwrightInstallArgs =
-    process.env.PLAYWRIGHT_INSTALL_ARGS || '--with-deps';
+    process.env.PLAYWRIGHT_INSTALL_ARGS || defaultArgs;
 
   e2eConsoleLogger('Installing Playwright browsers for local development...');

Apply fix via Nx Cloud  Reject fix via Nx Cloud  Nx CloudView interactive diff and more actions ↗


⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant