-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(core): replace the pagination from the tui tasks list with scrolling #32560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit b2acfb7
☁️ Nx Cloud last updated this comment at |
3c067de
to
54b4a0b
Compare
54b4a0b
to
beae75b
Compare
beae75b
to
b2acfb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud is proposing a fix for your failed CI:
We fixed the e2e test failures by modifying the Playwright installation logic to avoid the --with-deps
flag in CI environments. This prevents apt package manager lock conflicts that were causing the tests to fail when multiple processes tried to install system dependencies simultaneously.
We could not verify this fix.
diff --git a/e2e/utils/get-env-info.ts b/e2e/utils/get-env-info.ts
index 20173dd..ce5038f 100644
--- a/e2e/utils/get-env-info.ts
+++ b/e2e/utils/get-env-info.ts
@@ -178,8 +178,10 @@ export function ensurePlaywrightBrowsersInstallation() {
}
// Only install browsers for local development
+ // In CI environments, avoid --with-deps to prevent apt lock conflicts
+ const defaultArgs = process.env.CI ? '' : '--with-deps';
const playwrightInstallArgs =
- process.env.PLAYWRIGHT_INSTALL_ARGS || '--with-deps';
+ process.env.PLAYWRIGHT_INSTALL_ARGS || defaultArgs;
e2eConsoleLogger('Installing Playwright browsers for local development...');
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
Current Behavior
The TUI tasks list uses pagination when it has many tasks that don't fit in the viewport.
Expected Behavior
The TUI tasks list should be scrollable and not use pagination.
Additionally, this PR includes a fix so that when a task is selected in the task list, it's always ensured that the task is visible if resizing the terminal or when the task is moved due to a different status.