Newer generated files use module_or_path rather than input#39
Open
justindthomas wants to merge 4 commits intonshen:mainfrom
Open
Newer generated files use module_or_path rather than input#39justindthomas wants to merge 4 commits intonshen:mainfrom
module_or_path rather than input#39justindthomas wants to merge 4 commits intonshen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like
wasm-bindgenmay have changed at some point, but I can't identify a commit at that repository where that would be the case. Regardless, the.jsfiles the newer versions generate seem to usemodule_or_pathwhere they usedinputpreviously and that brokevite-plugin-wasm-pack. I adjusted the pattern to accommodate either situation.I also incorporated a change from another fork to make
incomingUrlmore flexible. I'm not sure if that's necessary - I was grasping a bit at first since Svelte plugins are unfamiliar to me.I also added some white space; the code felt cramped to me.