Enable linter for every module #3605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
fix-linter
branch
from
f0e17ba to
cbaaff2
Compare
NNS linter is still failing, but it's fixed in #3604. |
roman-khimov
reviewed
Oct 9, 2024
AnnaShaleva
force-pushed
the
fix-linter
branch
from
cbaaff2 to
aba3023
Compare
Not fixed yet, I need to read about proper configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3605 +/- ##
==========================================
- Coverage 85.25% 85.22% -0.04%
==========================================
Files 333 333
Lines 39009 39009
==========================================
- Hits 33258 33244 -14
- Misses 4180 4199 +19
+ Partials 1571 1566 -5 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
force-pushed
the
fix-linter
branch
from
aba3023 to
1cbfb56
Compare
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Avoid situations like 9f93123. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
fix-linter
branch
from
1cbfb56 to
e2b0095
Compare
AnnaShaleva
commented
Oct 10, 2024
AnnaShaleva
force-pushed
the
fix-linter
branch
3 times, most recently
from
13039ac to
9d83eaa
Compare
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
fix-linter
branch
2 times, most recently
from
d9144dc to
96b5f80
Compare
roman-khimov
approved these changes
Oct 11, 2024
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Enable linter for examples, scripts and interop packages. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
fix-linter
branch
from
96b5f80 to
8bdb8af
Compare
|
Let's see if re-run helps with CodeQL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
9f93123
Solution
Make it green.