Added :collects attribute to %CustomCollection{}#94
Open
Rutaba wants to merge 16 commits intonsweeting:masterfrom
Rutaba:master
Open
Added :collects attribute to %CustomCollection{}#94Rutaba wants to merge 16 commits intonsweeting:masterfrom Rutaba:master
Rutaba wants to merge 16 commits intonsweeting:masterfrom
Rutaba:master
Conversation
According to the shopify documentation (https://help.shopify.com/en/api/reference/products/customcollection), the Collect resource is used to connect a product to a custom collection using the :collects attribute which was missing here.
as per Shopify API version 2020-01 added the updated to include additional image details
Added the new fields and deleted the deprecated field :requires_shipping as per Shopify API 2020-01
removed :metafields, :metafields_global_title_tag, :metafields_global_description_tag to keep it updated with shopify API version 2020-01
added :accepts_marketing_updated_at, :metafield, :marketing_opt_in_level and :tax_exemptions
updated the struct as per Shopify API version 2020-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the [shopify documentation(https://help.shopify.com/en/api/reference/products/customcollection)], the Collect resource is used to connect a product to a custom collection using the :collects attribute which was missing here.