Update on input fixes #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; ple frame limiting;
added tests for pong and raycastmaze
Parameter verification for Pong and RaycastMaze
…d and updated tests
Changed pong collision to use pygame built-in
Test Update __init__.py
Update __init__.py
|
Thank you for your work on this. It looks great. I left a few comments. |
ntasfi
requested changes
Mar 25, 2019
| @@ -261,7 +263,7 @@ def step(self, dt): | |||
| self.bad_creep.update(ndx, ndy, dt) | |||
| self.good_creep.update(dt) | |||
|
|
|||
| self.player.draw(self.screen) | |||
| #self.player.draw(self.screen) | |||
| is_pad_hit = True | ||
|
|
||
| #then we test the cpu, much cleaner! | ||
| if pygame.sprite.collide_rect(self, cpuPlayer): |
There was a problem hiding this comment.
Can you verify that this does not slow down the step speed? I believe using this function was slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.