Skip to content

Fix nats telemetry client#3043

Closed
jotare wants to merge 6 commits intomainfrom
fix-nats-telemetry-client
Closed

Fix nats telemetry client#3043
jotare wants to merge 6 commits intomainfrom
fix-nats-telemetry-client

Conversation

@jotare
Copy link
Contributor

@jotare jotare commented Apr 8, 2025

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team April 8, 2025 09:40
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (5fdf981) to head (3c2ed2b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/search/app.py 12.50% 7 Missing ⚠️
...iadb_telemetry/src/nucliadb_telemetry/jetstream.py 62.50% 6 Missing ⚠️
nucliadb/src/nucliadb/search/openapi.py 0.00% 2 Missing ⚠️
nucliadb/src/nucliadb/search/run.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3043   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         498      498           
  Lines       37262    37280   +18     
  Branches    11645    11645           
=======================================
+ Hits        31422    31438   +16     
- Misses       5294     5295    +1     
- Partials      546      547    +1     
Flag Coverage Δ
nidx 78.25% <ø> (-0.08%) ⬇️
nucliadb-ingest 40.53% <8.33%> (-0.05%) ⬇️
nucliadb-reader 41.72% <8.33%> (-0.06%) ⬇️
nucliadb-standalone 45.86% <8.33%> (-0.05%) ⬇️
nucliadb-train 44.10% <8.33%> (-0.04%) ⬇️
nucliadb-writer 46.70% <8.33%> (+0.05%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 81.25% <ø> (ø)
nucliadb_sdk 93.09% <ø> (ø)
nucliadb_telemetry 85.50% <62.50%> (-0.34%) ⬇️
nucliadb_utils 84.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jotare added 4 commits April 8, 2025 12:11
Otherwise, instrumentation in tests doesn't work and we're probably
testing against the same running application with state across tests
@jotare
Copy link
Contributor Author

jotare commented Apr 11, 2025

Superseded by #3053

@jotare jotare closed this Apr 11, 2025
@javitonino javitonino deleted the fix-nats-telemetry-client branch January 20, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant