Remove VersionedFastAPI + add telemetry to tests#3053
Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
==========================================
- Coverage 84.19% 84.06% -0.13%
==========================================
Files 502 503 +1
Lines 37847 37742 -105
Branches 11808 11808
==========================================
- Hits 31865 31729 -136
- Misses 5427 5457 +30
- Partials 555 556 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Otherwise, instrumentation in tests doesn't work and we're probably testing against the same running application with state across tests
jotare
force-pushed
the
add-telemetry-to-tests
branch
from
e75c293 to
01049ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VersionedFastAPI was giving us more trouble than benefit. A simple prefix in our routers replaces the functionality we were using from VersionedFastAPI. In addition, removing this fixes a subtle bug where two FastAPIs were created with the same middleware, causing multiple calls to those middlewares (auth, audit...) per request.
How was this PR tested?
Describe how you tested this PR.