Skip to content

fix: propogate health status for pipeline #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Apr 13, 2025

Fixes #2070

  • updated cluster summary api to return health status based on health checker to return critical and warning status
  • TODO: cover the same status for mono vertex, also the monoVertex health is hardcoded to healthy in both backend and UI.

Signed-off-by: veds-g <guptavedant2312@gmail.com>
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 69.56%. Comparing base (eb4dd43) to head (cf556b7).

Files with missing lines Patch % Lines
server/apis/v1/handler.go 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
- Coverage   69.59%   69.56%   -0.04%     
==========================================
  Files         391      391              
  Lines       58130    58162      +32     
==========================================
+ Hits        40458    40462       +4     
- Misses      16589    16620      +31     
+ Partials     1083     1080       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@veds-g veds-g marked this pull request as ready for review April 14, 2025 19:39
@veds-g veds-g requested review from whynowy and vigith as code owners April 14, 2025 19:39
@@ -269,7 +269,29 @@ func (h *handler) GetClusterSummary(c *gin.Context) {
if value, ok := namespaceSummaryMap[pipeline.Namespace]; ok {
summary = value
}
status, err := getPipelineStatus(&pipeline)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How bad is the performance (e.g.with 20, 50 pipelines)?

@veds-g veds-g marked this pull request as draft April 17, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Unhealthy pipeline does not propagate to namespace overview
2 participants