Security patch: don't trust data by default in tables #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Je pense qu'il faudrait effectivement appliquer ce changement de logique partout d'un coup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
Comme discuté sur Mattermost, cette PR supprime la confiance par défault dans les cellules du tableau généré par
dsfr_tableet documente comment protéger le HTML contre l'échappement.C'est évidemment un breaking change, donc je peux proposer une configuration
DSFR_SAFE_STRING_DEFAULTqui est àTruepar défaut avec un warning qui indique que l'option disparaîtra à la prochaine majeure et qu'il faudra utilisermark_safe.Je réflchis à retirer le filtre
safeà d'autres endroits aussi.