[T4A5][T11-B3] #1685
Open
[T4A5][T11-B3] #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stal and block classes validate whether the correct number has been entered and if so how many digit numbers have been added (postal code has 6 digits).
…Phone classes are extended/inherited.
kychua
reviewed
Sep 21, 2016
There was a problem hiding this comment.
@dheerajaraj Some comments added. Please close the PR after reading
Avoid accumulating unrelated changes into a single PR.
Tip: If you are currently on branch1 and want to create a new branch2, you need to switch back to master branch before creating branch2. If not, changes in branch1 will appear in the PR created from branch2 later.
| import seedu.addressbook.data.person.*; | ||
| import seedu.addressbook.data.tag.UniqueTagList.DuplicateTagException; | ||
|
|
||
| public class Tagging { |
| public class Tagging { | ||
| private int status; | ||
| private Person person; | ||
| private UniqueTagList alltags; |
There was a problem hiding this comment.
based on the diagram given, this should not be here. Tagging is just the association between a Person and a Tag
| import seedu.addressbook.data.tag.UniqueTagList.DuplicateTagException; | ||
|
|
||
| public class Tagging { | ||
| private int status; |
| } | ||
|
|
||
| public String toString(){ | ||
| String action = (status==1) ? "+" : "-"; |
| for(Tag tag: alltags){ | ||
| result += tag.toString(); | ||
| } | ||
| return result; |
There was a problem hiding this comment.
Coding standard violation! One more more of these problems detected:
- extra/missing spaces.
- brace style problem.
- missing braces.
- name doesn't follow naming convention
|
|
||
| } | ||
|
|
||
| public Tagging(int status, ReadOnlyPerson targetPerson, Tag tag) throws DuplicateTagException{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.