Skip to content

build: Updated PlantUML dependency to 1.2025.0 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Oliver-Loeffler
Copy link

Hello there,

thank you for providing this great add-on for Gitbucket. Unfortunately I've encountered a few .puml files which could not be rendered with PlantUML 1.2022.5 but with later 1.2024. versions. This version is prrovided by plugin version 1.7.0.
So I've decided to see, if I can provide an update in form of a PR.

This PR includes:

  • Updated PlantUML ASL to 1.2025.0
  • builds with Java 17 to JDK 1.8 target
  • Requires at least GitBucket 4.36.0 or later (unfortunately I was not able to obtain all transitive dependencies for earlier Gitbucket versions).
  • Reworked SBT build file to eliminate slash API warnings
  • Tested with GitBucket 4.36.0 and GitBucket 4.39.0

Interestingly PlantUML changed the SVG character encoding from UTF-8 to u-sascii.

I would greatly appreciate if you would be able to review this proposal. Please advice if you see need for rework.
My proposal for this is to call it version 1.8.0.

Thank you!

}
} getOrElse NotFound
} getOrElse NotFound()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was proposed by SBT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant