Skip to content

Fixed _v4 changes in some files #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed _v4 changes in some files #723

wants to merge 2 commits into from

Conversation

abhinavbansal29
Copy link
Collaborator

No description provided.

bhati-pradeep
bhati-pradeep suggested changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@bhati-pradeep bhati-pradeep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm if vgs modules in future/ are already done or not, we can remove it.

Haroon-Dweikat-Ntx
Haroon-Dweikat-Ntx approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Haroon-Dweikat-Ntx Haroon-Dweikat-Ntx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GullapalliAkhil
GullapalliAkhil reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@GullapalliAkhil GullapalliAkhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made are part of any bugs raised? If yes can you add the bug id or atleast some reference in the description? Please make sure to add the Pull Request Description it helps for the reviewers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GullapalliAkhil GullapalliAkhil GullapalliAkhil left review comments

@Haroon-Dweikat-Ntx Haroon-Dweikat-Ntx Haroon-Dweikat-Ntx approved these changes

@abhimutant abhimutant Awaiting requested review from abhimutant

+1 more reviewer

@bhati-pradeep bhati-pradeep bhati-pradeep requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinavbansal29 @GullapalliAkhil @bhati-pradeep @Haroon-Dweikat-Ntx