Update brlapi X64 #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think this will get merged? Or will we have to maintain a fork? |
|
I'm not sure. Probably depends on what @DaveMielke says about brltty/brltty#490 |
|
Given Dave is unresponsive, could you open a PR to https://github.com/nvaccess/brltty? |
|
Note, since NV Access now produces these binaries, may be it should be considered to sign them? |
|
@LeonarddeR - are there any potential benefits to signing them? I think we may want to do some level of auditing of this code before signing |
|
I'm not sure whether it's really worth it, but liblouis is also signed. That said, espeak.dll is not, so there is a bit of inconsistency here. |
5 tasks
SaschaCowley
pushed a commit
to nvaccess/nvda
that referenced
this pull request
Oct 3, 2025
Closes #18657 Merges changes from nvaccess/brltty#1 and nvaccess/nvda-misc-deps#39 ### Summary of the issue: BRLTTY needs to be updated for 64bit and python 3.13. Since updating python it has been broken on alphas. ### Description of user facing changes: BRLTTY restored usage restored ### Description of developer facing changes: None ### Description of development approach: Update commit from miscDeps built from https://github.com/nvaccess/brltty/pull/ ### Testing strategy: Unit tests re-enabled ### Known issues with pull request: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix nvaccess/nvda#18657 when part of NVDA X64 builds.
Updated to a brlapi build produced on Github Actions in my own fork. See also brltty/brltty#490
Tested successfully: