Skip to content

Conversation

Lee31416
Copy link

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Updating the contributing documentation

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.
    • Only code in the Benchmarks project was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

@Lee31416 Lee31416 changed the title dev/topi/update-contributing-doc docs: Updating contributing documentation Mar 29, 2025
@Lee31416 Lee31416 force-pushed the dev/topi/update-contributing-doc branch from fce9803 to 79713e6 Compare March 29, 2025 05:18
Add a quick description of your changes.

Impact on version:
Please check the impact of your changes on the version. This should align with the changes made to the changelog file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BREAKING_CHANGES.md should be the one we look at, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's why I said the pr template doesn't align with what i wrote there on some packages

@Lee31416 Lee31416 closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants