feat(extra): add <C-e> mapping for pickers.history

Author: TheLeoP

CHANGELOG.md

@@ -55,6 +55,8 @@ There are following change types:
 
 - Add `pickers.colorschemes` picker. By @pkazmier, PR #1789.
 
+- Add `<C-e>` mapping for `pickers.history` picker to edit commands or searches in cmdline. By @TheLeoP, PR #1960.
+
 ## mini.files
 
 ### Refine

doc/mini-extra.txt

@@ -512,13 +512,15 @@ Return ~
                `MiniExtra.pickers.history`({local_opts}, {opts})
 Neovim history picker
 
-Pick from output of |:history|.
+Pick from output of |:history|. Use `<C-e>` to edit current match in cmdline.
 Notes:
 - Has no preview.
 - Choosing action depends on scope:
     - For "cmd" / ":" scopes, the command is executed.
     - For "search" / "/" / "?" scopes, search is redone.
     - For other scopes nothing is done (but chosen item is still returned).
+- `<C-e>` only works for "cmd" / ":" / "search" / "/" / "?" scopes. It does
+  nothing for all other scopes.
 
 Examples ~
 

lua/mini/extra.lua

@@ -921,13 +921,15 @@ end
 
 --- Neovim history picker
 ---
---- Pick from output of |:history|.
+--- Pick from output of |:history|. Use `<C-e>` to edit current match in cmdline.
 --- Notes:
 --- - Has no preview.
 --- - Choosing action depends on scope:
 ---     - For "cmd" / ":" scopes, the command is executed.
 ---     - For "search" / "/" / "?" scopes, search is redone.
 ---     - For other scopes nothing is done (but chosen item is still returned).
+--- - `<C-e>` only works for "cmd" / ":" / "search" / "/" / "?" scopes. It does
+---   nothing for all other scopes.
 ---
 --- Examples ~
 ---
@@ -978,6 +980,17 @@ MiniExtra.pickers.history = function(local_opts, opts)
     end
   end
 
+  local edit_command = function()
+    local cur_match = MiniPick.get_picker_matches().current
+    local scope
+    scope, cur_match = cur_match:match('^([:/?]) (.*)')
+    if scope ~= ':' and scope ~= '/' and scope ~= '?' then return end
+    vim.schedule(function() vim.api.nvim_input(scope .. cur_match) end)
+    return true
+  end
+  local mappings = { edit_command = { char = '<C-e>', func = edit_command } }
+
+  opts = vim.tbl_deep_extend('force', opts or {}, { mappings = mappings })
   local default_source = { name = string.format('History (%s)', scope), preview = preview, choose = choose }
   return H.pick_start(items, { source = default_source }, opts)
 end

tests/screenshots/tests-test_extra.lua---pickers---history()---has-custom-'edit_command'-mapping

@@ -0,0 +1,43 @@
+--|---------|---------|---------|---------|---------|---------|---------|
+01|                                                                      
+02|~                                                                     
+03|~                                                                     
+04|~                                                                     
+05|~                                                                     
+06|~                                                                     
+07|┌> @▏───────────────────────────────────────┐                         
+08|│@ input 2                                  │                         
+09|│@ input 1                                  │                         
+10|│                                           │                         
+11|│                                           │                         
+12|│                                           │                         
+13|│                                           │                         
+14|│                                           │                         
+15|│                                           │                         
+16|│                                           │                         
+17|│                                           │                         
+18|│                                           │                         
+19|└ History (all) ───────────────────── 1|2|8 ┘                         
+20|                                                                      
+
+--|---------|---------|---------|---------|---------|---------|---------|
+01|0000000000000000000000000000000000000000000000000000000000000000000000
+02|1111111111111111111111111111111111111111111111111111111111111111111111
+03|1111111111111111111111111111111111111111111111111111111111111111111111
+04|1111111111111111111111111111111111111111111111111111111111111111111111
+05|1111111111111111111111111111111111111111111111111111111111111111111111
+06|1111111111111111111111111111111111111111111111111111111111111111111111
+07|2334522222222222222222222222222222222222222221111111111111111111111111
+08|2677777777777777777777777777777777777777777721111111111111111111111111
+09|2899999999999999999999999999999999999999999921111111111111111111111111
+10|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+11|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+12|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+13|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+14|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+15|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+16|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+17|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+18|2:::::::::::::::::::::::::::::::::::::::::::21111111111111111111111111
+19|2;;;;;;;;;;;;;;;222222222222222222222;;;;;;;21111111111111111111111111
+20|0000000000000000000000000000000000000000000000000000000000000000000000

tests/test_extra.lua

@@ -2463,6 +2463,28 @@ T['pickers']['history()']['validates arguments'] = function()
   validate({ scope = '1' }, '`pickers%.history`.*"scope".*"1".*one of')
 end
 
+T['pickers']['history()']['has custom "edit_command" mapping'] = function()
+  child.set_size(20, 70)
+
+  pick_history()
+  eq(child.lua_get('MiniPick.get_picker_opts().mappings.edit_command.char'), '<C-e>')
+
+  type_keys(':', '<C-e>')
+  eq(child.fn.getcmdtype(), ':')
+  eq(child.fn.getcmdline(), 'lua _G.n = _G.n + 2')
+
+  type_keys('<C-c>')
+  pick_history()
+  type_keys('/', '<C-e>')
+  eq(child.fn.getcmdtype(), '/')
+  eq(child.fn.getcmdline(), 'bbb')
+
+  type_keys('<C-c>')
+  pick_history()
+  type_keys('@', '<C-e>')
+  child.expect_screenshot({})
+end
+
 T['pickers']['hl_groups()'] = new_set()
 
 local pick_hl_groups = forward_lua_notify('MiniExtra.pickers.hl_groups')