Getting error E565 when using MiniSnippets.expand()

[rohrsben]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.snippets

Question

I'm not sure whether this belongs here or under blink.cmp so, apologies!

I'm trying to make blink and mini.snippets play nice with each other, which has been a bit of a journey. Here's my goal currently:

• disable all mini.snippet keybinds
• set a blink keybind to either accept the current selection, or if none, call MiniSnippets.expand()

Here's what the keybinds look like in blink (I also set snippets.preset = 'mini_snippets'):

keymap = {
    preset = 'none',
    ['<C-j>']   = { 'select_next', 'fallback' },
    ['<C-k>']   = { 'select_prev', 'fallback' },
    ['<C-c>']   = { 'cancel', 'fallback' },
    ['<C-e>']   = {
        'accept',
        function ()
            MiniSnippets.expand()
        end
    },
    ['<Tab>']   = { 'snippet_forward', 'fallback' },
    ['<S-Tab>'] = { 'snippet_backward', 'fallback' },
 },

The issue is that, as in the title, I get error E565 with a stacktrace pointing to mini, specifically

in nvim_buf_set_text
... in mini: delete_region
... in mini: call_in_insert_mode
... in mini: insert
... in mini: select
... in mini: expand
... in blink: command

The (bigger??) issue is that I can't find a reproduction of this. I did a minimal init.lua which only installed blink and mini (and only set relevant parts of each) and the snippet expanded just fine! To be clear, when using this, I do not make a selection in the blink menu; I just type out the prefix and hit <C-e>. I also tried to find a single culprit by removing my other plugins one at a time, (though I added them back in before removing again because otherwise the number of combos to test gets... big) with no luck.

Am I calling MiniSnippets.expand() incorrectly? I tried with both select and match set to false, but no dice. Long story short, any leads are appreciated!

Editing to add some other simple things I tried:

• deleting/rebuilding .local/{share, state}/nvim
• adding a return true or return false to the <C-e> function
• require('mini.snippets').expand() instead of MiniSnippets.expand()

Second edit to add the motivation:
When trying out the example snippets, (only!) "Choices" has a problem where the blink menu does not disappear. If I trigger the snippet through blink, however, the menu does disappear. There's another issue where the choice menu is gigantic and includes a ton of extra stuff besides just a|b, but I think that's a separate issue. I figured I could just move the snippet expansion into the blink keymap to fix it. It might not work in the end, but I can't even test it to find out lol

[abeldekat]

Hello @rohrsben,

It's a bit difficult to help without seeing your full config for blink and mini.snippets.

As you are using MiniSnippets.expand, I assume:

1. You want mini.snippets to handle all snippets from the lsp, selected with blink
2. You don't want blink to present all other snippets.

I do something similar when using blink, and there are some caveats indeed. See my config for blink and mini.snippets.

EDIT: Could you add the following to the options for mini.snippet?

-- ...
  expand = {
    select = function(snippets, insert)
        require("blink.cmp").cancel() -- cancel uses vim.schedule
        vim.schedule(function() MiniSnippets.default_select(snippets, insert) end)
    end,
  },
-- ...

[abeldekat]

You're welcome!

[rohrsben]

Now that I can expand a snippet this way, I do have another question that I briefly mentioned above. No worries if you can't help!

ch is the prefix for the example "Choice" snippet, which is just some choice nodes, the first being a|b and the second c|d. If I expand the snippet manually, the first node pops up a list with the options a and b as expected. If instead I select ch~ in the blink menu and expand it that way, however, no menu shows up until I hit <C-n> (next option binding) and then I get a menu with seemingly... every possible completion in the buffer? Tabbing over to the second node and then back shows the correct options menu.

Obviously I can just hide personal snippets from blink now that I can expand them, but I wonder if this will happen if an lsp-provided snippet uses choice nodes?

[abeldekat]

I can reproduce the behavior you describe.

init.lua

---@diagnostic disable: undefined-global
local function setup_deps(path_to_site)
  local mini_path = path_to_site .. "pack/deps/start/mini.nvim"
  if not vim.uv.fs_stat(mini_path) then
    vim.cmd('echo "Installing `mini.nvim`" | redraw')
    vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/echasnovski/mini.nvim", mini_path })
    vim.cmd("packadd mini.nvim | helptags ALL")
    vim.cmd('echo "Installed `mini.nvim`" | redraw')
  end
  require("mini.deps").setup({ path = { package = path_to_site } })
end
setup_deps(vim.fn.stdpath("data") .. "/site/")

local use_blink = false -- test "ch" snippet also without blink...
vim.g.mapleader = " "
MiniDeps.now(function()
  require("mini.basics").setup()
  require("mini.icons").setup()
  require("mini.notify").setup()
  vim.notify = MiniNotify.make_notify()

  local mini_snippets, config_path = require("mini.snippets"), vim.fn.stdpath("config")
  mini_snippets.setup({
    snippets = {
      mini_snippets.gen_loader.from_file(config_path .. "/snippets/global.json"),
      mini_snippets.gen_loader.from_lang(),
    },
  })

  if use_blink then
    MiniDeps.add({ source = "saghen/blink.cmp", checkout = "v1.1.1" })
    require("blink.cmp").setup({
      snippets = { preset = "mini_snippets" },
    })
  end

  MiniDeps.add("williamboman/mason.nvim")
  require("mason").setup() -- and install lua_language_server

  MiniDeps.add("neovim/nvim-lspconfig")
  vim.lsp.enable({ "lua_ls" })
end)

snippets/global.json

{
  "Basic": { "prefix": "ba", "body": "T1=$1 T2=$2 T0=$0" },
  "Placeholders": { "prefix": "pl", "body": "T1=${1:aa}\nT2=${2:<$1>}" },
  "Choices": { "prefix": "ch", "body": "T1=${1|a,b|} T2=${2|c,d|}" },
  "Linked": { "prefix": "li", "body": "T1=$1\n\tT1=$1" },
  "Variables": { "prefix": "va", "body": "Runtime: $VIMRUNTIME\n" },
  "Complex": {
    "prefix": "co",
    "body": ["T1=${1:$RANDOM}", "T3=${3:$1_${2:$1}}", "T2=$2"]
  }
}

Obviously I can just hide personal snippets from blink now that I can expand them, but I wonder if this will happen if an lsp-provided snippet uses choice nodes?

Yes, I think that will also happen with an lsp-provided snippet.
@echasnovski, what's your opinion?

[echasnovski]

@echasnovski, what's your opinion?

This looks like a side effect of 'Saghen/blink.cmp' trying to do dot repeat. As choices are shown via built-in completion menu, it is totally reasonable that it can be affected by something hacky when trying to enable dot-repeat. The following config does not show the issue:

require('blink.cmp').setup({
  snippets = { preset = 'mini_snippets' },
  completion = {
    accept = {
      dot_repeat = false,
    },
  },
})

---

... no menu shows up until I hit (next option binding) and then I get a menu with seemingly... every possible completion in the buffer?

@rohrsben, a bit explanation about this. Choices are shown using built-in completion menu, which has hard-coded <C-n> and <C-p> to navigate to next and previous item respectively (see :h ins-completion-menu). However, if no menu is visible, those keys act as to start special built-in keyword completion (see :h i_CTRL-N and :h i_CTRL-P). That's why you see "every possible completion in the buffer", which in fact is probably a bit more than that and can be configured via :h 'complete'.

[rohrsben]

In awe of y'alls knowledge. Thanks @echasnovski, and thanks again @abeldekat! This worked, and I don't even know what dot-repeating blink would do, so I shall live in blissful ignorance with working choice nodes.