refactor(utils): replace utils.open() with vim.open()#891
Merged
kristijanhusak merged 1 commit intonvim-orgmode:masterfrom Feb 5, 2025
Merged
Conversation
kristijanhusak
approved these changes
Feb 5, 2025
Member
kristijanhusak
left a comment
There was a problem hiding this comment.
IIRC this util was for Neovim < 0.10 or some older version that didn't have vim.ui.open. It can be removed now since it's 0.10+.
Thanks for these cleanup PRs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the function
utils.open()and replaces it withvim.ui.open().As far as I can tell, this helper was only used in
export.lua. Hyperlinks usedvim.ui.open()from the start.The utils function does basically the same as the built-in, except:
Related Issues
Extracted from #878
Changes
utils.open()in export.lua withvim.ui.open()Checklist
I confirm that I have:
feat: add new feature,fix: correct bug,docs: update documentation).make test.