-
-
Notifications
You must be signed in to change notification settings - Fork 624
enable deprecated warnings, minimum neovim version 0.9, harden support for greater versions #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We shouldn't be concerned about development versions prior to 0.10. We should support:
|
That works for me. We can continue to use the simple vim.fn test and keep the code clean. The only issue is users on 0.10 dev versions (debian!), which do break. Could we just show a startup warning like "...proceed at your own risk..." ? |
I couldn't find a reliable way to detect dev versions; 0.9 is now the minimum and it's up to the user to deal with issues with dev versions. I did put off that diagnostic breakage until 0.11 as more users will likely raise issues. https://github.com/nvim-tree/nvim-tree.lua/pull/2788/files#diff-b4d683774fedaa8bdc2f7107576331513b01888c09ab2fcfd44468ef976c1b08 |
…le deprecated warnings (#2788) * refactor(#2787): replace deprecated * refactor(#2787): enable deprecated checks * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): use inline deprecation disabling * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): replace deprecated * refactor(#2787): deprecated are now warnings * refactor(#2787): 0.9 is the minimum supported version * Revert "refactor(#2787): replace deprecated" This reverts commit b6b4c32. * refactor(#2787): suppress deprecated until 0.11 * refactor(#2787): minimum nvim version 0.8 -> 0.9 * refactor(#2787): reset globals * refactor(#2787): explicitly check for vim.diagnostic.is_enabled function presence
Uh oh!
There was an error while loading. Please reload this page.
API changed many times during the 0.10 dev cycle. Many users are using various versions of 0.10 pre-release. We must ensure that the correct functions are being used. Resolves issues such as #2781 (comment)
We can use a lazily loaded cache of supported API. Requires minimum nvim version of 0.9
Testing
:h api-level
0.9.5
0.10.0
The text was updated successfully, but these errors were encountered: