Skip to content

chore(master): release nvim-tree 0.99.0 #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 1, 2024
Merged

chore(master): release nvim-tree 0.99.0 #2587

merged 2 commits into from
Jan 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 10, 2023 •
edited
Loading

🤖 I have created a release beep boop

0.99.0 (2024-01-01)

Features

Bug Fixes

Miscellaneous Chores

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot force-pushed the release-please--branches--master--components--nvim-tree branch from 63e019c to 2f0a53d Compare December 10, 2023 22:46
@alex-courtis
Copy link
Member

The release notes are all over the place, with no real order and only some changes present.

Now that we are using semantic PR subject, future releases should have "good" notes.

Proposal: remove this changelog completely, or just its contents. Future releases will have well generated, small changelogs.

We can experiment with new releases once this release is complete.

alex-courtis
alex-courtis reviewed Dec 10, 2023
View reviewed changes
CHANGELOG.md
# Changelog

## 0.9.0 (2023-12-10)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could go with something like "first release" or leave this blank and remove everything below.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like that huge, mostly meaningless, changelog either. Would need to look into how to stop it from being generated, this seems to be good option https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#starting-commit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could sneak that little change in with next merge to avoid polluting history. 🤷

Copy link
Member

@alex-courtis alex-courtis Dec 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, sounds like that starting commit would keep release please happy.

We can just make that change as a regular commit; we already have 4891d6c and 90cff8e

Let's do this!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2588 that might be all we need.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, let's do this.

Worst case? We have a large changelog that we clean later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed https://github.com/nvim-tree/nvim-tree.lua/actions/runs/7161359020/job/19496856718#step:2:44.
But once we have user facing commit on master it might do what we want it to, so would be good to get something with feat or fix next.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2571 merged... let's see...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch updated following CI "success": https://github.com/nvim-tree/nvim-tree.lua/actions/runs/7257707903/job/19771925430

It missed the tag bit - is there something we need to do?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try putting Release-As: 0.9.0 in body of some user facing PR (and squashed commit message(!)) at which point we will like to cut that release.

@github-actions github-actions bot changed the title chore(master): release nvim-tree 0.9.0 chore(master): release nvim-tree 1.0.0 Dec 19, 2023
@github-actions github-actions bot force-pushed the release-please--branches--master--components--nvim-tree branch 2 times, most recently from 71c2052 to 6610a38 Compare December 19, 2023 10:29
@github-actions github-actions bot force-pushed the release-please--branches--master--components--nvim-tree branch 4 times, most recently from b7ec6c9 to f46cb5a Compare January 1, 2024 01:37
@github-actions github-actions bot changed the title chore(master): release nvim-tree 1.0.0 chore(master): release nvim-tree 0.99.0 Jan 1, 2024
@github-actions github-actions bot force-pushed the release-please--branches--master--components--nvim-tree branch from f46cb5a to 2e60311 Compare January 1, 2024 01:41
@alex-courtis alex-courtis merged commit f1b3e6a into master Jan 1, 2024
@alex-courtis alex-courtis deleted the release-please--branches--master--components--nvim-tree branch January 1, 2024 01:46
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jan 1, 2024

🤖 Release is at https://github.com/nvim-tree/nvim-tree.lua/releases/tag/nvim-tree-v0.99.0 🌻

@alex-courtis
Copy link
Member

Worked beautifully - tag was applied after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-courtis alex-courtis alex-courtis left review comments

@gegoune gegoune gegoune left review comments

Assignees
No one assigned
Labels
autorelease: tagged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-courtis @gegoune